Open
Conversation
✅ Deploy Preview for nptemplating-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dwertheimer
reviewed
Dec 24, 2022
Contributor
dwertheimer
left a comment
dwertheimer
left a comment
There was a problem hiding this comment.
@edgauthier Thank you so much for doing this! I am tweaking the fields a little because I found a way to simplify it a bit. I will send you a DM. @mikeerickson let's hold on this for a moment so that Ed can updated it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Documentation for the new templateRunner command that @dwertheimer is working on.
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?
Completeness and accuracy. Documentation was written based on my use of the command, input from @dwertheimer , and some code inspection.