Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a changelog for #967 #968

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Add a changelog for #967 #968

merged 1 commit into from
Oct 6, 2024

Conversation

toku-sa-n
Copy link
Collaborator

Description of the PR

Please see the title.

Checklist

mihaimaruseac
mihaimaruseac approved these changes Oct 6, 2024
View reviewed changes
Copy link
Owner

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I always forget to do that.

But then we'll need to also go through the code and remove all the special cases and pragmas for it. Right now we're just not testing it, but the codepaths are still there.

@mihaimaruseac mihaimaruseac merged commit d58e4e6 into mihaimaruseac:master Oct 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toku-sa-n @mihaimaruseac