Skip to content

[oadp-1.5] updates for 1.4 compat #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: oadp-1.5
Choose a base branch
from
Open

[oadp-1.5] updates for 1.4 compat #319

wants to merge 5 commits into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #314

/assign mpryc

weshayutin and others added 4 commits September 22, 2025 19:59
@weshayutin
updates for 1.4 compat
7150916 
Signed-off-by: Wesley Hayutin <[email protected]>
@weshayutin
ensure go mod is built for 1.4
3549a48
@mpryc
Fixes to build with oadp-1.4
8f67f0e 
Signed-off-by: Michal Pryc <[email protected]>
@mpryc @claude
Fixes of the Status.Update() calls and use Patch for finalizer
b590553 
Modifications which allows to remove race condition in the
Status and Finalizer updates.

Fixed race condition in Status update.

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Michal Pryc <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2025
Merged
@openshift-ci openshift-ci bot requested review from mrnold and sseago September 22, 2025 19:59
@oadp-snyk
Copy link

oadp-snyk commented Sep 22, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from mpryc. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 22, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images c09faeb link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrnold mrnold Awaiting requested review from mrnold

@sseago sseago Awaiting requested review from sseago

At least 2 approving reviews are required to merge this pull request.

Assignees

@mpryc mpryc

Labels
do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @oadp-snyk @weshayutin @mpryc