Skip to content

fix(web): improve SmartSearch status accessibility #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drnecrotix wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(web): improve SmartSearch status accessibility #301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c84717
fix(web): improve SmartSearch status accessibility
drnecrotix Aug 11, 2026
0244816
Merge branch 'main' into fix/accessibility-small-improvements
drnecrotix Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions apps/web/app/components/SmartSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,18 +256,13 @@ export function SmartSearch({
Всички резултати за „{query.trim()}" →
</li>
)}

{!hasResults && !loading && (
<li className="smart-search-empty" role="presentation">
Няма съвпадения. Пробвай с име, ЕИК или УНП.
</li>
)}
{!hasResults && loading && (
<li className="smart-search-empty" role="presentation" aria-live="polite">
Търсене…
</li>
)}
</ul>

{!hasResults && (
<div className="smart-search-empty" role="status" aria-live="polite">

@ydimitrof ydimitrof Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добро подобрение — role="status" е правилният избор за обявяване на състояние към екранни четци вместо <li role="presentation">. Дребна забележка: role="status" вече включва имплицитно aria-live="polite" (и aria-atomic="true"), така че изричното aria-live="polite" е технически излишно. Може да се остави за яснота — безвредно е.

{loading ? 'Търсене…' : 'Няма съвпадения. Пробвай с име, ЕИК или УНП.'}

@ydimitrof ydimitrof Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проверете дали CSS класът smart-search-empty не е разчитал на това елементът да е <li> вътре в <ul> (напр. padding/подравняване, наследено от списъка). Сега елементът е <div> извън <ul>, така че визуалното оформление може леко да се различава.

</div>
)}
</div>
</div>
);
Expand Down