Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under recent versions of
pip
, thepygments-shader
package can't be installed because the setup.py loads a dependency beforesetup()
has executed:The simple fix would be to just simplify the code and just use
version='1.0.1'
in thesetup.py
file.However, that could potentially break users of the
pygments-shader
package that due to Hyrum's law could depend on the ability to refer to thepygments_shader.__version__
variable.So instead, this PR uses
SourceFileLoader
to load version.py from setup.py without also importing other stuff that is not yet ready. (thanks to @Guillemdb for teaching me that trick)