Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add Machine Scope DuongDieuPhap.ImageGlass.installer.yaml #133225

Conversation

PckgrBot
Copy link
Contributor

@PckgrBot PckgrBot commented Jan 8, 2024

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PckgrBot PckgrBot changed the title Update: Add Machie Scope DuongDieuPhap.ImageGlass.installer.yaml Update: Add Machine Scope DuongDieuPhap.ImageGlass.installer.yaml Jan 8, 2024
@PckgrBot
Copy link
Contributor Author

PckgrBot commented Jan 8, 2024

#133123

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 8, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jan 8, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jan 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 8, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Needs-Author-Feedback This needs a response from the author. labels Jan 8, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jan 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 8, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978334972

(Automated response - build 530.)

@PckgrBot
Copy link
Contributor Author

PckgrBot commented Jan 8, 2024

@stephengillie any advice on how I get solve this?

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jan 8, 2024
@stephengillie
Copy link
Collaborator

Manual Validation ended with:
image

@stephengillie
Copy link
Collaborator

This needs to be added at line 61. GitHub doesn't make it easy to suggest this.

  - PackageIdentifier: Microsoft.DotNet.DesktopRuntime.8

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 9, 2024
@PckgrBot
Copy link
Contributor Author

PckgrBot commented Jan 9, 2024

This needs to be added at line 61. GitHub doesn't make it easy to suggest this.

  - PackageIdentifier: Microsoft.DotNet.DesktopRuntime.8

Unless I'm missing something this is already in the manifest at line 61?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 9, 2024
@stephengillie
Copy link
Collaborator

Unless I'm missing something this is already in the manifest at line 61?

Yes, it is. Somehow it was missing from the version I was working with yesterday.

@stephengillie stephengillie self-assigned this Jan 10, 2024
@stephengillie
Copy link
Collaborator

Unless I'm missing something this is already in the manifest at line 61?

Yes, it is. Somehow it was missing from the version I was working with yesterday.

I see why now - I launched this validation with Get-ManifestFile which leverages Get-SecondMatch to perform the Get-Clipboard operation, then finds any 2 lines that have the same data before the colon, and clobbers the first. Because usually it's an old and new SHA256 key or other duplicated value. This is the first instance of an intentionally duplicated value, effectively.

@PckgrBot
Copy link
Contributor Author

Unless I'm missing something this is already in the manifest at line 61?

Yes, it is. Somehow it was missing from the version I was working with yesterday.

I see why now - I launched this validation with Get-ManifestFile which leverages Get-SecondMatch to perform the Get-Clipboard operation, then finds any 2 lines that have the same data before the colon, and clobbers the first. Because usually it's an old and new SHA256 key or other duplicated value. This is the first instance of an intentionally duplicated value, effectively.

OK all good! Let me know if you think there is anything else I can change.

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Installation-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 10, 2024
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit b8dd3e3 into microsoft:master Jan 10, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@PckgrBot PckgrBot deleted the Add-Machine-Scope-to-DuongDieuPhap.ImageGlass branch April 8, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Validation-Installation-Error Error installing application Waived-Validation-Installation-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants