Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand wdk-sys coverage to include spb-related headers #263

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

wmmc88
Copy link
Collaborator

@wmmc88 wmmc88 commented Jan 13, 2025

This pull request introduces support for SPB (Serial Peripheral Bus) drivers in the wdk-sys crate. The changes include adding new API subsets, updating configuration files, and generating bindings for SPB-related headers.

Adding SPB Support:

  • Added Spb variant to ApiSubset enum in crates/wdk-build/src/lib.rs and updated the impl Config block to include SPB headers (spb.h, reshub.h, pwmutil.h, spb/1.1/spbcx.h). [1] [2] [3]
  • Updated Cargo.toml files to include spb feature in crates/wdk-sys and example driver projects. [1] [2] [3] [4]
  • Added SPB bindings generation in crates/wdk-sys/build.rs and created crates/wdk-sys/src/spb.rs for SPB-specific bindings. [1] [2] [3] [4] [5] [6] [7]

Code Improvements:

  • Enhanced #[allow(clippy::wildcard_imports)] annotations across multiple files to include reasons for allowing wildcard imports. [1] [2] [3] [4]

Configuration Updates:

  • Modified .vscode/settings.json to include --all argument for rustfmt.

@wmmc88 wmmc88 self-assigned this Jan 13, 2025
@wmmc88 wmmc88 force-pushed the spb branch 2 times, most recently from 972c00e to eb47e2f Compare January 23, 2025 22:02
@wmmc88 wmmc88 force-pushed the spb branch 3 times, most recently from 0de1a1a to 0d24a01 Compare January 30, 2025 07:43
@wmmc88 wmmc88 marked this pull request as ready for review January 30, 2025 07:43
@wmmc88 wmmc88 requested review from Copilot, leon-xd, ankurung and a team January 30, 2025 07:44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • .vscode/settings.json: Language not supported
  • crates/wdk-sys/Cargo.toml: Evaluated as low risk
  • crates/wdk-sys/src/ntddk.rs: Evaluated as low risk
  • examples/sample-umdf-driver/Cargo.toml: Evaluated as low risk
  • crates/wdk-sys/src/wdf.rs: Evaluated as low risk
  • crates/wdk-sys/src/windows.rs: Evaluated as low risk
  • examples/sample-kmdf-driver/Cargo.toml: Evaluated as low risk
  • crates/wdk-sys/src/hid.rs: Evaluated as low risk
@wmmc88 wmmc88 marked this pull request as draft January 31, 2025 20:00
@wmmc88 wmmc88 marked this pull request as ready for review February 1, 2025 00:19
@wmmc88 wmmc88 removed the request for review from leon-xd February 1, 2025 00:25
@wmmc88 wmmc88 enabled auto-merge February 1, 2025 00:29
@wmmc88 wmmc88 added this pull request to the merge queue Feb 1, 2025
Merged via the queue into microsoft:main with commit 76cd29b Feb 1, 2025
62 checks passed
@wmmc88 wmmc88 deleted the spb branch February 1, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants