fix: exclude static component attributes from hydration binding count#72
Merged
Conversation
Static attributes on component tags (e.g., title, data-action) were incorrectly counted as binding attributes, inflating the hydration index counter. This caused FAST-HTML binding comment markers (fe-b___BEGIN___COMMAND_DONE_MARKER___$LASTEXITCODEstart/end) to have wrong indices, breaking client-side hydration. The fix aligns with the Node.js BTR reference implementation which returns isBindingAttribute=false for static (non-handlebars) component attributes. Also fixes duplicate <f-template> blocks when a component is used in multiple parent templates by deduplicating in on_parse_component.
radium-v
reviewed
Mar 6, 2026
Contributor
|
@mohamedmansour I've opened a new pull request, #73, to work on those changes. Once the pull request is ready, I'll request review from you. |
mohamedmansour
force-pushed
the
fix/component-hydration-markers
branch
from
4033665 to
dd41785
Compare
akroshg
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static attributes on component tags (e.g., title, data-action) were incorrectly counted as binding attributes, inflating the hydration index counter. This caused FAST-HTML binding comment markers to have wrong indices, breaking client-side hydration.
The fix aligns with the Node.js BTR reference implementation which returns isBindingAttribute=false for static (non-handlebars) component attributes.
Also fixes duplicate blocks when a component is used in multiple parent templates by deduplicating in on_parse_component.