Skip to content

Remove dead code #243669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Remove dead code #243669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingModifiedNotebookEntry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ export class ChatEditingModifiedNotebookEntry extends AbstractChatEditingModifie
private readonly cellEntryMap = new ResourceMap<ChatEditingNotebookCellEntry>();
private modifiedToOriginalCell = new ResourceMap<URI>();
private readonly _cellsDiffInfo = observableValue<ICellDiffInfo[]>('diffInfo', []);
private readonly _maxModifiedLineNumbers = observableValue<number[]>('changedMaxLineNumber', []);

get cellsDiffInfo(): IObservable<ICellDiffInfo[]> {
return this._cellsDiffInfo;
Expand Down Expand Up @@ -182,7 +181,6 @@ export class ChatEditingModifiedNotebookEntry extends AbstractChatEditingModifie
this.originalModel = this._register(originalResourceRef).object.notebook;
this.originalURI = this.originalModel.uri;
this.initialContent = initialContent;
this._maxModifiedLineNumbers.set(this.modifiedModel.cells.map(() => 0), undefined);
this.initializeModelsFromDiff();
this._register(this.modifiedModel.onDidChangeContent(this.mirrorNotebookEdits, this));
}
Expand Down Expand Up @@ -514,7 +512,8 @@ export class ChatEditingModifiedNotebookEntry extends AbstractChatEditingModifie
if (!isLastEdits) {
this._stateObs.set(WorkingSetEntryState.Modified, tx);
this._isCurrentlyBeingModifiedByObs.set(responseModel, tx);
this._rewriteRatioObs.set(Math.min(1, calculateNotebookRewriteRatio(this._cellsDiffInfo.get(), this.originalModel, this.modifiedModel)), tx);
const newRewriteRation = Math.max(this._rewriteRatioObs.get(), calculateNotebookRewriteRatio(this._cellsDiffInfo.get(), this.originalModel, this.modifiedModel));
this._rewriteRatioObs.set(Math.min(1, newRewriteRation), tx);

} else {
finishPreviousCells();
Expand Down Expand Up @@ -891,13 +890,9 @@ export class ChatEditingModifiedNotebookEntry extends AbstractChatEditingModifie
};
}
diffs.splice(entryIndex, 1, { ...entry });
const maxModifiedLineNumber = cellEntry.maxModifiedLineNumber.read(r);
const maxModifiedLineNumbers = this._maxModifiedLineNumbers.get().slice();
maxModifiedLineNumbers[index] = maxModifiedLineNumber;

transaction(tx => {
this.updateCellDiffInfo(diffs, tx);
this._maxModifiedLineNumbers.set(maxModifiedLineNumbers, tx);
});
}));

Expand Down
Loading