Ensure commits by others to a tracked upstream will update my graph (fix #234979) #235318
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @lszomoru |
818Nawaf
approved these changes
Dec 5, 2024
|
@gjsjohnmurray, thanks for the PR. I have not yet investigated the bug but always resolving base is not the way to go here. This code path is "very hot" as it is being executed very frequently. Resolving the base branch can result in one of more calls to |
…ll update graph (fix microsoft#234979)" This reverts commit 09ebab6.
|
@lszomoru fair point. I have reworked my change so it's less expensive. |
gjsjohnmurray
changed the title
|
@gjsjohnmurray, thanks! I will take a look at this next week. |
818Nawaf
approved these changes
Dec 5, 2024
818Nawaf
approved these changes
Dec 6, 2024
|
@lszomoru I hope you will find time to review this and consider merging. |
818Nawaf
approved these changes
Dec 16, 2024
818Nawaf
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #234979