[ffmpeg] Avoid empty type array which cause a msvc ICE#51571
Draft
xiaozhuai wants to merge 1 commit intomicrosoft:masterfrom
Draft
[ffmpeg] Avoid empty type array which cause a msvc ICE#51571xiaozhuai wants to merge 1 commit intomicrosoft:masterfrom
xiaozhuai wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
Author
|
I've send the patch to the upstream. Please do not merge this PR until it has been reviewed by the upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.libavformat/cbs.c includes this file with a different set of
CBS_*macros. In configurations using --disable-everything, all coded bitstream types may be disabled for that instance, leavingcbs_type_tableempty.This triggers a zero-sized array warning with MSVC and may lead to an internal compiler error with optimization enabled.
Add a NULL terminator and iterate until the terminator instead of using
FF_ARRAY_ELEMS(). The runtime behavior is unchanged.The code currently permits building an instance of cbs.c with no enabled coded bitstream types. In that case the generated table is empty. Make the table explicitly NULL-terminated so this configuration is valid C for compilers that reject or mishandle empty arrays.