Skip to content

[protobuf] Make target libprotoc opt-in for non-native builds #51545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dudantas wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[protobuf] Make target libprotoc opt-in for non-native builds #51545

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bc57a0e
[protobuf] Don't build libprotoc for non-native target builds
dudantas May 4, 2026
6633856
Enable libprotoc target builds and default feature
dudantas May 4, 2026
b58bc0a
Enable libprotoc feature and bump port-versions
dudantas May 5, 2026
41bf703
Explicitly detect libprotoc feature
dudantas May 5, 2026
a923eef
Merge branch 'master' into dudantas/protobuf-no-target-libprotoc
BillyONeal May 5, 2026
1734a03
Fix version database.
BillyONeal May 5, 2026
87db590
Update protobuf version database
dudantas May 5, 2026
cba970e
Use vcpkg_check_features
BillyONeal May 5, 2026
725bae7
Merge branch 'dudantas/protobuf-no-target-libprotoc' into pr-51545-pr…
dudantas May 5, 2026
7816fc5
Merge pull request #2 from BillyONeal/pr-51545-protobuf
dudantas May 5, 2026
306f32b
Merge branch 'master' into dudantas/protobuf-no-target-libprotoc
dudantas May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ports/brpc/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "brpc",
"version": "1.16.0",
"port-version": 1,
"description": "Industrial-grade RPC framework used throughout Baidu, with 1,000,000+ instances and thousands kinds of services, called \"baidu-rpc\" inside Baidu.",
"homepage": "https://github.com/apache/brpc",
"license": "Apache-2.0",
Expand All @@ -16,6 +17,7 @@
{
"name": "protobuf",
"features": [
"libprotoc",
"zlib"
]
},
Expand Down
9 changes: 7 additions & 2 deletions ports/offscale-libetcd-cpp/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
{
"name": "offscale-libetcd-cpp",
"version-date": "2019-07-10",
"port-version": 3,
"port-version": 4,
"description": "A C++ client library for etcd. etcd is a distributed, reliable key-value store.",
"homepage": "https://github.com/offscale/libetcd-cpp",
"dependencies": [
"grpc",
"protobuf",
{
"name": "protobuf",
"features": [
"libprotoc"
]
},
{
"name": "vcpkg-cmake",
"host": true
Expand Down
10 changes: 7 additions & 3 deletions ports/protobuf/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,13 @@ vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
zlib protobuf_WITH_ZLIB
)

if(VCPKG_TARGET_IS_UWP)
set(protobuf_BUILD_LIBPROTOC OFF)
else()
set(protobuf_BUILD_TARGET_LIBPROTOC OFF)
if("libprotoc" IN_LIST FEATURES)
set(protobuf_BUILD_TARGET_LIBPROTOC ON)
endif()

set(protobuf_BUILD_LIBPROTOC OFF)
if(NOT VCPKG_TARGET_IS_UWP AND (protobuf_BUILD_PROTOC_BINARIES OR protobuf_BUILD_TARGET_LIBPROTOC))
set(protobuf_BUILD_LIBPROTOC ON)
endif()

Expand Down
6 changes: 5 additions & 1 deletion ports/protobuf/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "protobuf",
"version": "6.33.4",
"port-version": 1,
"port-version": 2,
"description": "Google's language-neutral, platform-neutral, extensible mechanism for serializing structured data.",
"homepage": "https://github.com/protocolbuffers/protobuf",
"license": "BSD-3-Clause",
Expand All @@ -22,6 +22,10 @@
}
],
"features": {
"libprotoc": {
"description": "Build the libprotoc compiler library for target builds.",
"supports": "!uwp"
Comment thread
BillyONeal marked this conversation as resolved.
},
"zlib": {
"description": "ZLib based features like Gzip streams",
"dependencies": [
Expand Down
5 changes: 5 additions & 0 deletions versions/b-/brpc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "8817bf2f6ff3430e3a1f633d5778c750b344d2c2",
"version": "1.16.0",
"port-version": 1
},
{
"git-tree": "9d30e0402aea62dba456d47bf1b0c66f8f948021",
"version": "1.16.0",
Expand Down
6 changes: 3 additions & 3 deletions versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1478,7 +1478,7 @@
},
"brpc": {
"baseline": "1.16.0",
"port-version": 0
"port-version": 1
},
"brunocodutra-metal": {
"baseline": "2.1.4",
Expand Down Expand Up @@ -7206,7 +7206,7 @@
},
"offscale-libetcd-cpp": {
"baseline": "2019-07-10",
"port-version": 3
"port-version": 4
},
"ogre": {
"baseline": "14.5.2",
Expand Down Expand Up @@ -7946,7 +7946,7 @@
},
"protobuf": {
"baseline": "6.33.4",
"port-version": 1
"port-version": 2
},
"protobuf-c": {
"baseline": "1.5.2",
Expand Down
5 changes: 5 additions & 0 deletions versions/o-/offscale-libetcd-cpp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "35185a82e9bc91941e9361aa0fa39e5ca2d569af",
"version-date": "2019-07-10",
"port-version": 4
},
{
"git-tree": "70eb4516cd664f01e89d2701ae45ba05ea4c9d7a",
"version-date": "2019-07-10",
Expand Down
5 changes: 5 additions & 0 deletions versions/p-/protobuf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "b494487afde172cdfe637085ed60e96641d13bd6",
"version": "6.33.4",
"port-version": 2
},
{
"git-tree": "82a850caf35034a45596845a1d6e734b82f6a79a",
"version": "6.33.4",
Expand Down
Loading