[geo-utils] new port#51540
Draft
gistrec wants to merge 1 commit intomicrosoft:masterfrom
Draft
Conversation
Author
|
@microsoft-github-policy-service agree |
BillyONeal
requested changes
May 5, 2026
Member
BillyONeal
left a comment
There was a problem hiding this comment.
Unfortunately the name "geo-utils" in repology already refers to another component so I think we have to use the GitHubOrg-Repo form for this one.
I fixed these nitpicks and made that rename for you in gistrec#1
|
|
||
| # Header-only — no compiled artifacts to keep | ||
| file(REMOVE_RECURSE | ||
| "${CURRENT_PACKAGES_DIR}/debug" |
Member
There was a problem hiding this comment.
We should set VCPKG_BUILD_TYPE to release to avoid needing this part.
| "${CURRENT_PACKAGES_DIR}/lib" | ||
| ) | ||
|
|
||
| vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE") |
Member
There was a problem hiding this comment.
Quoth GPT 5.4:
License / Installed Content Findings
- Finding: upstream attribution appears incomplete in the installed package metadata
- Declared license:
Apache-2.0 - Observed installed content:
packages\geo-utils_x64-windows\include\geo\detail\math.hpp,include\geo\latlng.hpp,include\geo\poly.hpp,include\geo\spherical.hpp - Evidence: those headers state
Portions of this file are based on Google Maps Android Utilsand nameCopyright 2013 Google Inc.; upstream also ships aNOTICEfile with that attribution:buildtrees\geo-utils\src\v1.0.0-d48bd1e966.clean\include\geo\detail\math.hpp:1-12buildtrees\geo-utils\src\v1.0.0-d48bd1e966.clean\NOTICE:1-5
- Assessment: the SPDX license field
Apache-2.0still looks compatible, but the installedshare\geo-utils\copyrightcontains only the Apache license text and does not carry the upstreamNOTICEattribution. Since upstream includes aNOTICEfile and the installed headers explicitly identify derived Google code, this should be preserved in the package copyright material.
- Declared license:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Adds a new port for geo-utils — a header-only C++17 library for spherical (lat/lng) geometry: distance, bearing, polygon area, point-in-polygon, path proximity.
License: Apache-2.0. No runtime dependencies.
Which triplets are supported/not supported? Have you updated the CI baseline?
Header-only, builds and installs cleanly on
arm64-osxlocally. Should work on all triplets the upstream CMake supports (Linux gcc/clang, macOS AppleClang, Windows MSVC — verified by upstream CI). Noci.baseline.txtchanges needed.Does your PR follow the maintainer guide?
Yes — license expression, homepage, version, vcpkg-cmake / vcpkg-cmake-config dependencies, copyright via
vcpkg_install_copyright, no debug/lib leakage (header-only).If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes —
versions/g-/geo-utils.jsonandversions/baseline.jsonupdated.If you have added/updated a port: Have you added/updated a Versioning info?
Yes.
Test plan
./vcpkg install geo-utilssucceeds on arm64-osxfind_package(GeoUtils CONFIG REQUIRED)+geo::utils