Skip to content

[geo-utils] new port#51540

Draft
gistrec wants to merge 1 commit intomicrosoft:masterfrom
gistrec:add-geo-utils
Draft

[geo-utils] new port#51540
gistrec wants to merge 1 commit intomicrosoft:masterfrom
gistrec:add-geo-utils

Conversation

@gistrec
Copy link
Copy Markdown

@gistrec gistrec commented May 4, 2026

Describe the pull request

  • What does your PR fix?

    Adds a new port for geo-utils — a header-only C++17 library for spherical (lat/lng) geometry: distance, bearing, polygon area, point-in-polygon, path proximity.
    License: Apache-2.0. No runtime dependencies.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Header-only, builds and installs cleanly on arm64-osx locally. Should work on all triplets the upstream CMake supports (Linux gcc/clang, macOS AppleClang, Windows MSVC — verified by upstream CI). No ci.baseline.txt changes needed.

  • Does your PR follow the maintainer guide?

    Yes — license expression, homepage, version, vcpkg-cmake / vcpkg-cmake-config dependencies, copyright via vcpkg_install_copyright, no debug/lib leakage (header-only).

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes — versions/g-/geo-utils.json and versions/baseline.json updated.

  • If you have added/updated a port: Have you added/updated a Versioning info?

    Yes.

Test plan

  • Local install ./vcpkg install geo-utils succeeds on arm64-osx
  • Post-build validation passes
  • Heuristic CMake target detection: find_package(GeoUtils CONFIG REQUIRED) + geo::utils
  • vcpkg CI on Linux/macOS/Windows

@gistrec
Copy link
Copy Markdown
Author

gistrec commented May 4, 2026

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the name "geo-utils" in repology already refers to another component so I think we have to use the GitHubOrg-Repo form for this one.

I fixed these nitpicks and made that rename for you in gistrec#1


# Header-only — no compiled artifacts to keep
file(REMOVE_RECURSE
"${CURRENT_PACKAGES_DIR}/debug"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should set VCPKG_BUILD_TYPE to release to avoid needing this part.

"${CURRENT_PACKAGES_DIR}/lib"
)

vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoth GPT 5.4:

License / Installed Content Findings

  • Finding: upstream attribution appears incomplete in the installed package metadata
    • Declared license: Apache-2.0
    • Observed installed content: packages\geo-utils_x64-windows\include\geo\detail\math.hpp, include\geo\latlng.hpp, include\geo\poly.hpp, include\geo\spherical.hpp
    • Evidence: those headers state Portions of this file are based on Google Maps Android Utils and name Copyright 2013 Google Inc.; upstream also ships a NOTICE file with that attribution:
      • buildtrees\geo-utils\src\v1.0.0-d48bd1e966.clean\include\geo\detail\math.hpp:1-12
      • buildtrees\geo-utils\src\v1.0.0-d48bd1e966.clean\NOTICE:1-5
    • Assessment: the SPDX license field Apache-2.0 still looks compatible, but the installed share\geo-utils\copyright contains only the Apache license text and does not carry the upstream NOTICE attribution. Since upstream includes a NOTICE file and the installed headers explicitly identify derived Google code, this should be preserved in the package copyright material.

@BillyONeal BillyONeal marked this pull request as draft May 5, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants