Skip to content

[vcpkg-tool-meson] Fixes for additional languages#51492

Draft
ajtribick wants to merge 1 commit intomicrosoft:masterfrom
ajtribick:meson-additional-languages
Draft

[vcpkg-tool-meson] Fixes for additional languages#51492
ajtribick wants to merge 1 commit intomicrosoft:masterfrom
ajtribick:meson-additional-languages

Conversation

@ajtribick
Copy link
Copy Markdown
Contributor

@ajtribick ajtribick commented May 1, 2026

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Relevant: #51404 (but I can't check whether this actually fixes it)

  • Match the template and variable names for Objective-C++
  • Use ADDITIONAL_LANGUAGES parameter for vcpkg_cmake_get_vars

Please double-check this! In particular, I have absolutely no idea why the existing method of passing additional languages for Meson works with glib and not with harfbuzz! From what I can see based on local testing, using the ADDITIONAL_LANGUAGES parameter works for both.

Since I don't have any platforms that actually build the Objective-C/C++ code, I have verified this by the entries being created in the meson-${platform}-dbg.log files.

@BillyONeal
Copy link
Copy Markdown
Member

@abique Can you confirm that this works? I'm reluctant to merge something for a bug for which we do not have a repro and we don't have a clear understanding of what happened.

@ajtribick
Copy link
Copy Markdown
Contributor Author

It would also be useful to know whether this works with glib as well as harfbuzz.

@BillyONeal
Copy link
Copy Markdown
Member

I'm drafting this not because anything needs to change in the code but because I can't merge it until we have that "before/after", "broken/working" demonstration. Thanks for your submission!

@BillyONeal BillyONeal marked this pull request as draft May 4, 2026 22:53
@ajtribick ajtribick force-pushed the meson-additional-languages branch from 9857567 to e5e6d29 Compare May 6, 2026 05:31
- Match the template and variable names for Objective-C++
- Use ADDITIONAL_LANGUAGES parameter for vcpkg_cmake_get_vars
@ajtribick ajtribick force-pushed the meson-additional-languages branch from e5e6d29 to 112e17e Compare May 6, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants