Fix version database consistency check.#51408
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Apr 27, 2026
Merged
Conversation
In microsoft#51374 I broke the consistency check if there are edits to ports/ which aren't in the user's branch because their branch is out of date. Demonstration of it being broken: microsoft#51187 This fixes that. Co-authored-by: Copilot <[email protected]>
BillyONeal
commented
Apr 27, 2026
| git clean -fd -- versions | ||
| ./vcpkg x-add-version --all --skip-formatting-check | grep -E '^warning:|instead of "version-string"' | tee .github-pr.version-string.out || true | ||
| # check for version format errors separately by running x-add-version --all, recording problems it generates | ||
| ./vcpkg x-add-version --all | grep -E '^warning:|instead of "version-string"' | tee .github-pr.version-string.out || true |
Member
Author
There was a problem hiding this comment.
I got rid of --skip-formatting-check because it's unnecessary. We already ran format-manifest --all above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #51374 I broke the consistency check if there are edits to ports/ which aren't in the user's branch because their branch is out of date.
Demonstration of it being broken: #51187
This fixes that.