[steamworks-sdk] New port#51368
Conversation
@microsoft-github-policy-service agree |
|
Drafting due to build failures. |
…nclude, include/steam/lib/
…remove lib directories, and exclude Windows ARM64
vicroms
left a comment
There was a problem hiding this comment.
This port is packaging prebuilt binaries and creating a CMake wrapper on top of those bits. Aside from that, the way it downloads the Steamworks SDK is not compatible with our asset caching mechanism.
if(STEAMWORKS_USE_SDK_MIRROR)
set(SWSDK_LINK "https://github.com/Waffle0823/SteamworksSDK-Mirror/archive/refs/tags/v${SWSDK_VERSION}.tar.gz" CACHE STRING "Steamworks SDK download link")
else()
string(REPLACE "." "" SWSDK_VERSION_NODOT "${SWSDK_VERSION}")
set(SWSDK_LINK "https://partner.steamgames.com/downloads/steamworks_sdk_${SWSDK_VERSION_NODOT}.zip" CACHE STRING "Steamworks SDK download link")
endif()
_steamworks_download_sdk(STEAMWORKS_SDK_ROOT)|
@vicroms |
There was a problem hiding this comment.
Can I ask is there any way to make pre-built assets compatible with asset caching system?
All touching the network needs to be in portfile.cmake and use vcpkg_download_distfile or one of the helpers that transitively calls that.
At a minimum "steamworks-sdk" seems to be known in repology for coming from https://partner.steamgames.com/downloads/list and it's not even clear that the sources this is using are supposed to be public. The content at https://github.com/Waffle0823/SteamworksSDK-Mirror does not have a license grant from Valve allowing that content to be redistributed, and all their official downloads go to a login page for me. The existence of https://github.com/Waffle0823/SteamworksSDK-Mirror may constitute copyright infringement.
I don't think even changing the name to waffle0823-steamworks-sdk to avoid the naming problem fixes the situation; I think we need a statement from Valve that this is acceptable, or a documented license allowing redistribution of this, to proceed.
|
https://partner.steamgames.com/documentation/sdk_access_agreement I am not a lawyer but they appear to be explicitly prohibiting redistribution to me, emphasis mine:
|
Thanks for your response. |
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.