Skip to content

Conversation

@allanhanan
Copy link

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

This is my first time creating a port, Let me know if theres any changes to be made!

New Windows DirectShow UVC camera control library port.
@allanhanan
Copy link
Author

@microsoft-github-policy-service agree

@allanhanan
Copy link
Author

allanhanan commented Jan 8, 2026

Updated the portfile to fix build issues

  • Installed usage file into share/duvc-ctl
  • Added vcpkg_fixup_pkgconfig() to clean .pc files
  • Corrected static/shared linkage options

edit: forgot to x-add-version after making changes, force pushed after running it (a85625b)

@allanhanan allanhanan force-pushed the duvc-ctl-2.0.1 branch 2 times, most recently from a85625b to 39642e9 Compare January 8, 2026 15:03
@allanhanan
Copy link
Author

UWP tests failed as this library doesnt support it. Updated vcpkg.json to exclude uwp, formatted it and made sure to do x-add-version and force pushed it (39642e9)

set(DUVC_BUILD_STATIC ON)
endif()

vcpkg_configure_cmake(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the CMake calls with the functios from the vcpkg-cmake helper port (vcpkg_cmake_configure, vcpkg_cmake_install, and vcpkg_cmake_config_fixup).

@vicroms vicroms marked this pull request as draft January 8, 2026 22:20
@allanhanan allanhanan marked this pull request as ready for review January 9, 2026 08:07
@allanhanan
Copy link
Author

I've made the changes and it passed the CI tests. Ready for review. Let me know if there's anything else to change!

@allanhanan allanhanan requested a review from vicroms January 9, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants