-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[duvc-ctl] Add new port v2.0.1#0 #49291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
New Windows DirectShow UVC camera control library port.
|
@microsoft-github-policy-service agree |
522d11f to
5a68993
Compare
|
Updated the portfile to fix build issues
edit: forgot to x-add-version after making changes, force pushed after running it (a85625b) |
a85625b to
39642e9
Compare
|
UWP tests failed as this library doesnt support it. Updated vcpkg.json to exclude uwp, formatted it and made sure to do x-add-version and force pushed it (39642e9) |
ports/duvc-ctl/portfile.cmake
Outdated
| set(DUVC_BUILD_STATIC ON) | ||
| endif() | ||
|
|
||
| vcpkg_configure_cmake( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace the CMake calls with the functios from the vcpkg-cmake helper port (vcpkg_cmake_configure, vcpkg_cmake_install, and vcpkg_cmake_config_fixup).
39642e9 to
986330b
Compare
|
I've made the changes and it passed the CI tests. Ready for review. Let me know if there's anything else to change! |
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.This is my first time creating a port, Let me know if theres any changes to be made!