Skip to content

Conversation

@solemnwarning
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@solemnwarning solemnwarning marked this pull request as ready for review January 1, 2026 23:14
@solemnwarning
Copy link
Contributor Author

A local build of botan for x86-windows succeeds for me, so unsure if perhaps the CI just randomly fell over. There doesn't appear to be a way I can do a retrigger or get the build log out of the Azure CI system.

@vicroms
Copy link
Member

vicroms commented Jan 6, 2026

This specifically fails when installing the amalgamation feature on x86, the error is the following:

botan_all.cpp(4587): error C2672: 'Botan::bitvector_base<Botan::secure_allocator>::blockwise_processing_callback_trait<FnT,Botan::bitvector_base<Botan::secure_allocator>::BitRangeOperator<Botan::bitvector_base<Botan::secure_allocator>,Botan::bitvector_base<Botan::secure_allocator>::BitRangeAlignment::byte_aligned>,Botan::bitvector_base<Botan::secure_allocator>::BitRangeOperator<const OtherT,Botan::bitvector_base<Botan::secure_allocator>::BitRangeAlignment::byte_aligned>>::apply': no matching overloaded function found
        with
        [
            FnT=Botan::bitvector_base<Botan::secure_allocator>::&=::<lambda_1>,
            OtherT=Botan::secure_bitvector
        ]

@vicroms vicroms marked this pull request as draft January 6, 2026 09:37
@solemnwarning solemnwarning marked this pull request as ready for review January 8, 2026 16:59
@solemnwarning
Copy link
Contributor Author

Amalgamation build under x86 has been fixed upstream (randombit/botan#5216) and patch applied here.

@vicroms vicroms merged commit 826b8d0 into microsoft:master Jan 8, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants