[curl] Update to 8.18.0 #48563
Merged
[curl] Update to 8.18.0 #48563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| # The on-the-fly tarballs do not carry the details of release tarballs. | ||
| vcpkg_replace_string("${SOURCE_PATH}/include/curl/curlver.h" [[-DEV"]] [["]]) | ||
| vcpkg_replace_string("${SOURCE_PATH}/include/curl/curlver.h" [[LIBCURL_TIMESTAMP "[unreleased]"]] [[LIBCURL_TIMESTAMP "[vcpkg]"]]) |
Contributor
There was a problem hiding this comment.
Should this maybe include the port version like vcpkg-2?
Contributor
Author
There was a problem hiding this comment.
- The port version isn't readily available as a CMake variable.
(I don't want to read the manifest for an optional property.) - If we were using official tarballs, the value would also be const for one version.
- If there was a strong desire for details, we might use (a fragment of) the directory name of
SOURCE_PATH(e.g.c-8_18_0-1-f780f9182e.clean->f780f9182e). It is unique for a combination of sources and patches.
Contributor
Author
|
This is the infamous CMake-breaks-link-library-order-for-traditional-linker. |
Contributor
Author
|
Only linking |
Contributor
Author
A: Upstream links using the cmake variables (expecting filepaths), not the cmake targets. |
Contributor
Author
This the result of Now that the CURL config package has been around for so long, I tend to simply follow upstream and let |
dg0yt
commented
Dec 10, 2025
ports/curl/vcpkg-cmake-wrapper.cmake
Outdated
| message(WARNING "CURL_LIBRARIES list at least one target. This will not work for use cases where targets are not resolved.") | ||
| endif() | ||
| # leave CURL_LIBRARIES as set by upstream (imported target) | ||
| message(WARNING "Cannot easily unroll CURL_LIBRARIES (\"${CURL_LIBRARIES}\") to filepaths. Exported CMake config must use \"find_dependency(CURL)\".") |
Contributor
Author
There was a problem hiding this comment.
I think this warning could be moved into a watch() action for read access. Then it is only emitted when the variable is actually read, not when a project uses the target directly.
Contributor
Author
|
Using
Cascaded from a dependency which uses CURL_LIBRARIES. Check again after dealing with first list.
|
vicroms
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to upstream changes.
I expect that the port needs to keep the build system patches in order to satisfy static linkage and multi-config requirements across CMake, pkg-config and curl-config.
LIBCURL_VERSIONandLIBCURL_TIMESTAMP#48495CURL_LIBRARIESwarning, [curl] Update to 8.18.0 #48563 (comment)Exported configuration is provided in four ways, and this is why the port keeps significant patching vs. pristine CURL:
curl-configscripts: non-Windows only. Single config.All link libs and lib dirs must be listed explicitly.
Our patch reduces duplicate link libs.
pkg-config: Single config.It is best practice to refer to depedencies via
Requiresinstead ofLibsif possible. But upstream does both, and it also forwardsprivateto the regular field for static builds.Our patch removes redundancy (causing extra work for dealing with
curl-config). This trimming significantly facilitates downstream analysis of linking issues.CURL::libcurl. Multi-config in vcpkg only.Our patching ensures that link libraries are found without requiring pkg-config and that multi-config use is possible. (It would be fairly easy to supply pkg-config, but this would not support multi-config.
As before, this is achieved by using the LINK_LIBRARIES results from pkg_check_modules.
CURL_LIBRARIES. Multi-config in vcpkg only.This is the legacy interface provided by the Find module. Such variables are often consumed in the expectation that they don't contain imported targets, i.e. not requiring
find_dependencyin downstream exports. The port used to try hard to satisfy this condition. With this PR, this will only be done in trivial cases (shared library linkage, or just OpenSSL and ZLIB dependencies). For other dependencies,CURL_LIBRARIESwill just point toCURL::libcurlas implemented upstream.(i.e. patching is reduced a little bit now.)