[sentry-native] Fix linux runtime error and windows usage #39122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
category:port-bug
dg0yt
suggested changes
Jun 4, 2024
Contributor
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
[sentry-native] Fix linux build error
AFAICT there is no build error. There is a runtime error.
And that's why CI won't sufficiently indicate that the change is okay.
Comment on lines
9
to
14
| - if(LINUX) | ||
| - target_sources(crashpad_handler PRIVATE | ||
| - ../client/pthread_create_linux.cc | ||
| - ) | ||
| - endif() | ||
| - |
Contributor
There was a problem hiding this comment.
IMO this change is incorrect. Cf. second part of #39114 (comment)
JonLiu1993
changed the title
added 3 commits
June 5, 2024 01:32
…/vcpkg into dev/Jon/sentry-native
Contributor
Author
|
Tested usage successfully by |
JonLiu1993
changed the title
WangWeiLin-MV
approved these changes
Jun 6, 2024
Contributor
WangWeiLin-MV
left a comment
WangWeiLin-MV
left a comment
There was a problem hiding this comment.
The port usage tests pass with the following triplets:
- x64-linux
- x64-windows-static
WangWeiLin-MV
added
the
info:needs-maintainer-attention
Contributor
|
The changes should also be upstreamed, to have them included in future releases. |
Contributor
Author
|
I have commit PR for upstream : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39114
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.