integrate install: Remove VS2015 integration.#2011
Open
BillyONeal wants to merge 1 commit intomicrosoft:mainfrom
Open
integrate install: Remove VS2015 integration.#2011BillyONeal wants to merge 1 commit intomicrosoft:mainfrom
BillyONeal wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the legacy Visual Studio 2015 / MSBuild 14 system-wide integration path from vcpkg integrate install, eliminating the need for admin elevation in that command.
Changes:
- Deleted VS2015/MSBuild 14 integration logic (including elevation-based file operations and targets file version parsing).
- Removed related messages and help text implying admin requirements or VS2015-specific behavior.
- Removed the now-obsolete unit test for targets file version parsing.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vcpkg/commands.integrate.cpp | Removes MSBuild 14 system-wide integration and elevation code paths. |
| src/vcpkg-test/integrate.cpp | Drops tests for removed find_targets_file_version() logic. |
| locales/messages.json | Removes VS2015/admin-related strings and updates Windows integrate help text. |
| include/vcpkg/commands.integrate.h | Removes find_targets_file_version() API declaration and Optional include. |
| include/vcpkg/base/message-data.inc.h | Removes corresponding message declarations and updates Windows help message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: MicrosoftDocs/vcpkg-docs#573
Related: MicrosoftDocs/vcpkg-docs#576
This means we no longer need the "restart ourselves as admin to fix it" dance.