Nuget warning when using binary cache #2000
Open
TobiasFunk wants to merge 2 commits intomicrosoft:mainfrom
Open
Nuget warning when using binary cache #2000TobiasFunk wants to merge 2 commits intomicrosoft:mainfrom
TobiasFunk wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates vcpkg’s NuGet invocations to use the newer -NoHttpCache switch instead of the deprecated -NoCache, avoiding deprecation warnings when NuGet is used for binary caching and .nupkg extraction.
Changes:
- Replace
-NoCachewith-NoHttpCachein NuGet install commands used by binary caching. - Replace
-nocachewith-NoHttpCachein the Windows.nupkgextraction path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vcpkg/binarycaching.cpp | Updates NuGet install flags for binary cache restore to use -NoHttpCache. |
| src/vcpkg/archives.cpp | Updates the NuGet-based .nupkg extraction command to use -NoHttpCache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey as vcpkg now uses nuget 7.3.0
i get this warning when using the binary cache
warning : "D:\vcpkg\downloads\tools\nuget-7.3.0-windows\nuget.exe" install -ForceEnglishOutput -Verbosity detailed -NonInteractive "D:\vcpkg\buildtrees\packages.config" -OutputDirectory "D:\vcpkg\packages" -ExcludeVersion -PreRelease -PackageSaveMode nupkg -DirectDownload -NoCache -Source ****
NoCache is deprecated and has been renamed to NoHttpCache. Please use NoHttpCache instead.
as we have always nuget-7.3.0 i think we can change to -NoHttpCache
This pull requests changes from -NoCache to -NoHttpCache
This should fix issue:
#1989