Skip to content

Ignore VSCode files #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isaaccorley
Copy link
Collaborator

Ignore Visual Studio Code project settings files that are stored in .vscode/

@isaaccorley isaaccorley added this to the 0.7.1 milestone Apr 22, 2025
@isaaccorley isaaccorley self-assigned this Apr 22, 2025
@adamjstewart
Copy link
Collaborator

Historically I have rejected OS-specific (.DS_Store, Thumb.db) or editor-specific (*.swp, *.sublime-workspace) files from our .gitignore because they are not specific to this project, and generally belong in a global ~/.gitignore file instead. https://github.com/github/gitignore also separates them in a Global directory. My concern is that there are several OSes and hundreds of editors, and I don't really want to put all of them in our .gitignore. How can we choose which to include and which to exclude? I've chosen to exclude all so far, but I'm open to opinions. VS Code and macOS are clearly popular enough to warrant exceptions.

@calebrob6
Copy link
Member

I'm 100% fine with having a bunch of editor and OS specific lines in our gitignore (clearly not results/, isaac_tmp_4/) as I don't see any sort of maintenance or bug risk here. You can put a comment at the top of the file:

#############################
### Hello from Adam, did you know about global gitignore (https://github.com/github/gitignore )? Please consider that before adding a line here, but also we won't bite if you open a PR, thanks!
#############################

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants