Skip to content

CopernicusFM: ensure test metadata is always within range #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

CopernicusFM: ensure test metadata is always within range #2710

merged 1 commit into from
Apr 15, 2025

Conversation

adamjstewart
Copy link
Collaborator

@robmarkcole encountered the following issue in #2707:

FAILED tests/models/test_copernicusfm.py::TestCopernicusFMBase::test_copernicusfm_variable - AssertionError: The input tensor is not within the configured range `[0.001, 510000000.0]`.

The problem is that random numbers between 0 and 1 are sometimes 0, which is outside the valid range. This PR adds 1 to ensure that it is always in range.

@adamjstewart adamjstewart added this to the 0.7.1 milestone Apr 7, 2025
@github-actions github-actions bot added the testing Continuous integration testing label Apr 7, 2025
isaaccorley
isaaccorley approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@isaaccorley isaaccorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@isaaccorley isaaccorley merged commit 02b68b9 into microsoft:main Apr 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaccorley isaaccorley isaaccorley approved these changes

Assignees
No one assigned
Labels
testing Continuous integration testing
Projects
None yet
Milestone
0.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjstewart @isaaccorley