Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of CTS and timeout tokens #4444

Merged
merged 11 commits into from
Dec 28, 2024
Merged

Better handling of CTS and timeout tokens #4444

merged 11 commits into from
Dec 28, 2024
+1,147 −932

Conversation

Evangelink
Copy link
Member

No description provided.

@Youssef1313
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Evangelink Evangelink marked this pull request as ready for review December 26, 2024 08:46
@Evangelink Evangelink changed the title Experiment with improving fixture tokens handling Better handling of CTS and timeout tokens Dec 26, 2024
@Youssef1313
Copy link
Member

Looks like something is still flaky? CooperativeCancellation_WhenTestCleanupTimeoutExpiresAndUserChecksToken_StepThrows is currently failing on MacOS release.

@Evangelink
Copy link
Member Author

@Youssef1313 I have done multiple rerun and it seems this is no longer flaky (or that the level of flakiness dropped enough)

@Evangelink Evangelink merged commit 8fe2465 into microsoft:main Dec 28, 2024
10 checks passed
@Evangelink Evangelink deleted the test-cts branch December 28, 2024 14:41
@Evangelink Evangelink mentioned this pull request Dec 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evangelink @Youssef1313