-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for data_serviceendpoint_kubernetes #926
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@muresan Thank you for your contribute. Can you help add AccTest to cover the new data source. And add separate schema(data source properties are simply compute=true
) and flatten function for data source not simply reuse the resource functions.
Thank you for your comment. I added the kubernetes service endpoint in the same way as the sonar cloud service endpoint was added. Can you give me an example of another data source that I should follow ? All service endpoints data sources are added in the same way. Thanks. |
@muresan Data source only need the required parameter to get the service connection, other properties are not required. In the scenario, you are using the common schema for the k8s service connection. This is OK as the common schema cover the minimal properties requirement. You can add the same properties as r.Schema["service_account"] = &schema.Schema{
Type: schema.TypeList,
MaxItems: 1,
Computed: true,
Elem: map[string]*schema.Schema{
"ca_cert": {
Type: schema.TypeString,
Computed: true,
},
"token": {
Type: schema.TypeString,
Computed: true,
},
},
} |
All Submissions:
I did not see tests added to the other data sources, so I did not add one for this one.
The linked issue has info about this PR
What about the current behavior has changed?
Issue Number: #877
Does this introduce a change to
go.mod
,go.sum
orvendor/
?Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information