Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tags to build pipeline #167

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

exocom
Copy link
Contributor

@exocom exocom commented Sep 2, 2020

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Adding the ability to set tags on build pipeline.

Issue Number:

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@exocom
Copy link
Contributor Author

exocom commented Sep 2, 2020

@xuzhang3 The tags schema is the same across multiple api endpoints (10+). I've placed it into models folder.

Is models a good place to put a shared schema?
I noticed other schemas are returned via a function. Is there any reason to wrap this in a function instead of exporting it directly? If so could you explain why?

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Sep 3, 2020

@exocom Some of the resources have the same base schema structure, so they are wrapped into util functions.
It's OK to put the shared schema into models folder if tags is shared among different resources.

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Sep 3, 2020

Hi @exocom , Can you help add AccTest to cover the new schema tags? I test with your branch, but tags cannot be added to the build definition. Looks like this is a service issues.

@exocom
Copy link
Contributor Author

exocom commented Sep 3, 2020

@xuzhang3 Good catch, there is a bug on the API. I've submitted an issue to MicrosoftDocs/vsts-rest-api-specs#429.

Also created an ACC test, however, waiting for feedback on the bug. Hopefully they can fix it otherwise will have to change the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants