Skip to content

Conversation

@lhecker
Copy link
Member

@lhecker lhecker commented Nov 7, 2025

Closes #18725

Validation Steps Performed

Functionality was observed under a
debugger while using PowerShell 5.

@github-actions

This comment has been minimized.

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks! 🙂

EDIT: aside from the build failure, of course. But that looks like it may be an easy fix.

// wait for the DA1 response below and effectively wait for both.
if (_lookingForCursorPosition)
{
writer.WriteUTF8("\x1b[6n"); // Cursor Position Report (DSR CPR)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝Moved to WriteDSRCPR()

@lhecker lhecker enabled auto-merge (squash) November 18, 2025 19:12
@lhecker lhecker merged commit 898b9e3 into main Nov 18, 2025
19 checks passed
@lhecker lhecker moved this to To Cherry Pick in Inbox Servicing Pipeline Nov 18, 2025
@lhecker lhecker deleted the dev/lhecker/18725-resize-cursor-position branch November 18, 2025 21:06
@lhecker
Copy link
Member Author

lhecker commented Nov 18, 2025

Market as Inbox Servicing Pipeline not for inbox, but for packaging as a nuget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Cherry Pick

Development

Successfully merging this pull request may close these issues.

ConPTY: Ask for the cursor position after each resize

3 participants