Skip to content

Conversation

AvishekDas5
Copy link
Contributor

@AvishekDas5 AvishekDas5 commented Sep 24, 2025

Summary

Fixed broken MSDN link in src/renderer/gdi/state.cpp line 611(was in line 591 at the time).

Details

  • Old link: https://support.microsoft.com/en-us/kb/94646 (404 error)
  • New link: https://learn.microsoft.com/en-us/windows/win32/gdi/character-widths
  • The original article was about GetCharABCWidths() and calculating text extents
  • Microsoft has migrated this content to their new Learn platform

Validation

  • New link works and points to the correct content
  • Content matches the original MSDN article topic

Closes #16439

AvishekDas5 and others added 2 commits September 23, 2025 19:43
## Summary
Fixed broken MSDN link in src/renderer/gdi/state.cpp line 591.

## Details  
- Old link: `https://msdn.microsoft.com/en-us/library/ms969909.aspx` (404 error)
- New link: `https://learn.microsoft.com/en-us/windows/win32/gdi/character-widths`
- The original article was about GetCharABCWidths() and calculating text extents
- Microsoft has migrated this content to their new Learn platform

## Validation
- [x] New link works and points to the correct content
- [x] Content matches the original MSDN article topic

Closes microsoft#16439
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Product-Meta The product is the management of the products. labels Sep 24, 2025
@lhecker lhecker enabled auto-merge (squash) September 24, 2025 11:37
@carlos-zamora
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lhecker lhecker merged commit 05a4afc into microsoft:main Sep 25, 2025
17 of 19 checks passed
@DHowett
Copy link
Member

DHowett commented Sep 25, 2025

image

Old link: https://msdn.microsoft.com/en-us/library/ms969909.aspx (404 error)

If this is the bad link, why is that not the link you changed?

@AvishekDas5
Copy link
Contributor Author

AvishekDas5 commented Sep 26, 2025

If this is the bad link, why is that not the link you changed?

I'm really sorry I listed the wrong link on the PR summary, the broken link was https://support.microsoft.com/en-us/kb/94646
which was changed. This is correctly listed in #16439

I made the correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Meta The product is the management of the products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Comment] Invalid URL
4 participants