TerminalControl: Support MinGW path translation style (C:\ -> C:/) #18759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
lhecker
approved these changes
Apr 9, 2025
| @@ -119,6 +120,11 @@ namespace winrt::Microsoft::Terminal::Control::implementation | |||
| pos += cchSingleQuoteEscape; | |||
| } | |||
|
|
|||
| if (translationStyle == PathTranslationStyle::MinGW) | |||
There was a problem hiding this comment.
This is entirely optional, but you could merge this with the following if condition if you wanted to:
if (translationStyle != PathTranslationStyle::MinGW && fullPath.size() >= 2 && fullPath.at(1) == L':')There was a problem hiding this comment.
Sorry for being late in getting back to this.
I thought it was clearer to early-out for the MinGW case to make it obvious that no further processing is required rather than combining the logic with the existing drive handling condition. Readers then know there will be no additional MinGW code further on in the function.
|
Thanks so much for doing this! I'll hold it for a little bit in case you take Leonard's suggestion, but we're otherwise clear to merge :) |
|
/apz run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
added
the
Needs-Tag-Fix
DHowett
pushed a commit
to MicrosoftDocs/terminal
that referenced
this pull request
Apr 25, 2025
Documents the new option introduced by microsoft/terminal#18759 Co-authored-by: Adam Butcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Support drag-n-drop path translation in the style used by MinGW programs. In particular for usage with shells like
ashfrom busybox (https://frippery.org/busybox/).Detailed Description of the Pull Request / Additional comments
Provides a new option "mingw" for "pathTranslationStyle".
Shown as "MinGW" with translation documented as
(C:\ -> C:/)in the UI.As per the other modes, this translates
\to/but stops there. There is no prefix/drive translation.Validation Steps Performed
Run using
busybox ashshell. Dragged directories and files from both local disks and network shares onto terminal. All were appropriately single quoted and had their backslashes replaced with forward slashes. They were directly usable by theashshell.Language files containing the other options have been updated to include the new one.
PR Checklist