Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - SuperBench v0.11.0 #654

Merged
merged 7 commits into from
Oct 10, 2024
Merged
Prev Previous commit
Next Next commit
Docs - Fix metrics name in user tutorial (#651)
**Description**
In result-summary.md line 73-74, the example of kernel-launch used
metrics 'kernel-launch/event_overhead' and
'kernel-launch/wall_overhead'.

But in micro-benchmarks.md line 20-21, the metric names are described as
'kernel-launch/event_time' and ' kernel-launch/wall_time'.

Solution: Use identical metric names described in micro-benchmarks.md.

#649

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hongtaozhang <hongtaozhang@microsoft.com>
Co-authored-by: Yifan Xiong <yifan.xiong@microsoft.com>
  • Loading branch information
4 people authored and yukirora committed Oct 8, 2024
commit 502732776e0a703c179e4052c07a2256d0b88c94
4 changes: 2 additions & 2 deletions docs/user-tutorial/data-diagnosis.md
Original file line number Diff line number Diff line change
@@ -83,8 +83,8 @@ superbench:
criteria: lambda x:x>0.05
categories: KernelLaunch
metrics:
- kernel-launch/event_overhead:\d+
- kernel-launch/wall_overhead:\d+
- kernel-launch/event_time:\d+
- kernel-launch/wall_time:\d+
rule1:
# Rule 1: If H2D_Mem_BW or D2H_Mem_BW test suffers > 5% downgrade, label it as defective
function: variance
4 changes: 2 additions & 2 deletions docs/user-tutorial/result-summary.md
Original file line number Diff line number Diff line change
@@ -70,8 +70,8 @@ superbench:
aggregate: True
categories: KernelLaunch
metrics:
- kernel-launch/event_overhead
- kernel-launch/wall_overhead
- kernel-launch/event_time
- kernel-launch/wall_time
nccl:
statistics: mean
categories: NCCL