Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the fully qualified name for the Zip and Unzip tasks #803

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

bstadick
Copy link
Contributor

Use the fully qualified task names Microsoft.Build.Tasks.Unzip and Microsoft.Build.Tasks.ZipDirectory to avoid name collisions with other msbuild task packages. Changes to other msbuild tasks in use like RemoveDir are less necessary as they are less likely to have a name conflict. The Unzip and ZipDirectory are newer msbuild tasks so packages are more likely to have made tasks with the same name in lieu of them not being originally present in the core msbuild tasks.

Resolution to issue #801.

Tested task target changes locally with use of MSBuildCommunityTasks and successfully generated nuget packages that contained the SBOM file.

Use the fully qualified task names Microsoft.Build.Tasks.Unzip and Microsoft.Build.Tasks.ZipDirectory to avoid name collisions with other msbuild task packages.
@bstadick bstadick requested a review from a team as a code owner November 15, 2024 21:16
@sfoslund
Copy link
Member

@baronfel is using the fully qualified name for built in MSBuild tasks like this the standard approach? I don't think I've ever seen this before and it doesn't seem to be common based on some quick research

@baronfel
Copy link
Member

This is a very reasonable thing to do when you have very generic Task names you're dealing with - this seems like a good correctness fix to me.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (869dbe6) to head (b310b29).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #803   +/-   ##
=======================================
  Coverage   70.13%   70.13%           
=======================================
  Files         277      277           
  Lines        8651     8651           
  Branches     1006     1006           
=======================================
  Hits         6067     6067           
  Misses       2065     2065           
  Partials      519      519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfoslund sfoslund merged commit 130bb04 into microsoft:main Dec 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants