Skip to content

Conversation

@iamAbhi-916
Copy link
Contributor

@iamAbhi-916 iamAbhi-916 commented Jan 5, 2026

Description

facebook/react-native@0ef21bf...9731e8e

Type of Change

  • Integration

Why

Integrate [0.82.0-nightly-20250902-9731e8ebc]

What

RNW commit range
(https://github.com/facebook/react-native/compare/5936f29d6...0ef21bf8a)
https://github.com/facebook/react-native/commit/df748ba083924df0c8454cbdca19f5ec62fe9d7e

Review this commit as well.
check conflicts ref: 4217248

commit for conflict resolution : bb50808

commit for removal of legacy apis : bf1b74f
(didnt delete the files, just removed the apis)

commit for deleting legacy files: 7dd720d

Testing

Detailed test plan and artefacts : #15530
Tested playground + debugger in fresh machine. Below is the demo of the same -

test_in_fresh_machine.mp4

--

Changelog

Should this change be included in the release notes: no

Optional: Describe the tests that you ran locally to verify your changes.

Integrated 0.82.0-nightly-20250902-9731e8ebc into React Native Windows

Microsoft Reviewers: Open in CodeFlow

@iamAbhi-916 iamAbhi-916 changed the title Release integration 82 Integrate 0.82.0-nightly-20250902-9731e8ebc Jan 5, 2026
@iamAbhi-916 iamAbhi-916 requested review from a team as code owners January 7, 2026 13:13
Copy link
Contributor

@vineethkuttan vineethkuttan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the integration part.

@sundaramramaswamy
Copy link
Contributor

sundaramramaswamy commented Jan 9, 2026

Is this purely an integration change or does also have removal of old arch code? If it's the latter, I don't see Playground (composition) overwriting Playground. If we want a new-arch-clean repo, all vnext stuff should come to root and old stuff should go away. That would be an involved change. Is that planned for 0.82 or for any future version?

@sundaramramaswamy
Copy link
Contributor

sundaramramaswamy commented Jan 9, 2026

Would we be dropping all #ifdef RNW_NEW_ARCH references and promote new arch code to be the only code path?

@sundaramramaswamy
Copy link
Contributor

sundaramramaswamy commented Jan 9, 2026

I'm not reviewing all of the version number changes. Just FYI.

Copy link
Contributor

@sundaramramaswamy sundaramramaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments. I only reviewed C++ changes.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Jan 9, 2026
@iamAbhi-916
Copy link
Contributor Author

Is this purely an integration change or does also have removal of old arch code? If it's the latter, I don't see Playground (composition) overwriting Playground. If we want a new-arch-clean repo, all vnext stuff should come to root and old stuff should go away. That would be an involved change. Is that planned for 0.82 or for any future version?

This is an integration change that includes deprecation of legacy APIs, which RNW must also adhere to by removing legacy APIs.

Note: Not all legacy code has been removed by upstream yet.
Ref: https://github.com/facebook/react-native/blob/9731e8ebc5ea87526a91b9903172639e062cd920/packages/react-native/ReactCommon/react/runtime/ReactInstance.h#L16

React Native's New Architecture header (react/runtime/ReactInstance.h) includes jsireact/JSIExecutor.h, which transitively pulls in legacy cxxreact headers that have C4996 deprecation warnings. This is an upstream React Native issue.

Regarding Playground:

The legacy playground was already removed. The current structure clearly reflects the Composition/Fabric implementation.
Ref: #15354

From 0.82, users will already know that Fabric is the only build option.

The folder is named packages/playground/windows/playground-composition because:

Package name = playground (npm package identity, marked as private, hence not found on npm)
Ref:

Windows project = playground-composition (the Fabric/Composition implementation)

Regarding moving vnext to root:
This would be overkill for what is essentially a cosmetic change. Additionally, we haven't yet removed all legacy code, so we don't know the potential hiccups involved—React Native itself hasn't completed this process either. A major folder restructure at this point would be premature and risks breaking existing documentation, build scripts, and CI pipelines without any functional benefit.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) labels Jan 9, 2026
@iamAbhi-916
Copy link
Contributor Author

Would we be dropping all #ifdef RNW_NEW_ARCH references and promote new arch code to be the only code path?

Yeah we would do it in future but its part of this integartion. For now, It's used primarily in codegen-generated files (e.g., vnext/codegen/react/components/rnwcore/*.g.h) and sample custom components, core Microsoft.ReactNative code in vnext does not use RNW_NEW_ARCH guards—it's already New Architecture only.

@iamAbhi-916 iamAbhi-916 self-assigned this Jan 12, 2026
@iamAbhi-916 iamAbhi-916 removed the Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) label Jan 12, 2026
@HariniMalothu17 HariniMalothu17 self-requested a review January 13, 2026 09:01
Copy link
Contributor

@HariniMalothu17 HariniMalothu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes via rn tester app.Looks good to me

Copy link
Contributor

@protikbiswas100 protikbiswas100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamAbhi-916 iamAbhi-916 dismissed sundaramramaswamy’s stale review January 13, 2026 11:11

All comments are addressed!

@iamAbhi-916 iamAbhi-916 merged commit da1e74c into microsoft:main Jan 13, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants