-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Integrate 0.82.0-nightly-20250902-9731e8ebc #15517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate 0.82.0-nightly-20250902-9731e8ebc #15517
Conversation
…htly-20250902-9731e8ebc
…er --write <file-name>
vineethkuttan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the integration part.
|
Is this purely an integration change or does also have removal of old arch code? If it's the latter, I don't see Playground (composition) overwriting Playground. If we want a new-arch-clean repo, all |
|
Would we be dropping all |
|
I'm not reviewing all of the version number changes. Just FYI. |
sundaramramaswamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address comments. I only reviewed C++ changes.
vnext/Desktop.IntegrationTests/React.Windows.Desktop.IntegrationTests.vcxproj
Show resolved
Hide resolved
...n/TEMP_UntilReactCommonUpdate/react/renderer/components/view/accessibilityPropsConversions.h
Show resolved
Hide resolved
...n/TEMP_UntilReactCommonUpdate/react/renderer/components/view/accessibilityPropsConversions.h
Show resolved
Hide resolved
...n/TEMP_UntilReactCommonUpdate/react/renderer/components/view/accessibilityPropsConversions.h
Show resolved
Hide resolved
This is an integration change that includes deprecation of legacy APIs, which RNW must also adhere to by removing legacy APIs. Note: Not all legacy code has been removed by upstream yet. React Native's New Architecture header (react/runtime/ReactInstance.h) includes jsireact/JSIExecutor.h, which transitively pulls in legacy cxxreact headers that have C4996 deprecation warnings. This is an upstream React Native issue. Regarding Playground: The legacy playground was already removed. The current structure clearly reflects the Composition/Fabric implementation. From 0.82, users will already know that Fabric is the only build option. The folder is named packages/playground/windows/playground-composition because: Package name = playground (npm package identity, marked as private, hence not found on npm)
Windows project = playground-composition (the Fabric/Composition implementation) Regarding moving vnext to root: |
Yeah we would do it in future but its part of this integartion. For now, It's used primarily in codegen-generated files (e.g., vnext/codegen/react/components/rnwcore/*.g.h) and sample custom components, core Microsoft.ReactNative code in vnext does not use RNW_NEW_ARCH guards—it's already New Architecture only. |
HariniMalothu17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changes via rn tester app.Looks good to me
protikbiswas100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All comments are addressed!
Description
facebook/react-native@0ef21bf...9731e8e
Type of Change
Why
Integrate [0.82.0-nightly-20250902-9731e8ebc]
What
RNW commit range
(https://github.com/facebook/react-native/compare/5936f29d6...0ef21bf8a)
https://github.com/facebook/react-native/commit/df748ba083924df0c8454cbdca19f5ec62fe9d7e
Review this commit as well.
check conflicts ref: 4217248
commit for conflict resolution : bb50808
commit for removal of legacy apis : bf1b74f
(didnt delete the files, just removed the apis)
commit for deleting legacy files: 7dd720d
Testing
Detailed test plan and artefacts : #15530
Tested playground + debugger in fresh machine. Below is the demo of the same -
test_in_fresh_machine.mp4
--
Changelog
Should this change be included in the release notes: no
Optional: Describe the tests that you ran locally to verify your changes.
Integrated 0.82.0-nightly-20250902-9731e8ebc into React Native Windows
Microsoft Reviewers: Open in CodeFlow