Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate nonlocal games 1596 task2 ghz quantum #1840

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

ggridin
Copy link
Contributor

@ggridin ggridin commented Aug 14, 2024

The link to the issue: #1596

This pull request covering

  1. GHZ quantum tasks 2.1 (creating entangled triple).
  2. GHZ quantum task 2.2 (quantum strategies).
  3. Quantum strategy discussion.
  4. GHZ quantum task 2.3 (quantum game) is converted to demo.

@ggridin
Copy link
Contributor Author

ggridin commented Aug 14, 2024

Testing done:

  • Build "python ./build.py" is successful
  • Placeholder cases are syntactically correct but failing verifications.
  • Solutions are successful.
  • Some other failure scenarios were tested manually

GHZ Create Entangled Triple
GHZ Create Entangled Triple - Solution
GHZ Quantum Strategy
GHZ Quantum Strategy - Solution
GHZ Discussion 1
GHZ Discussion 2
GHZ Game E2E

@tcNickolas
Copy link
Member

This week got crazy, so I didn't get to reviewing this - sorry about that! I'll look on Monday, my calendar is a lot clearer then

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the two tasks this PR adds and left some comments. I'll take a look at the discussion and the demo tomorrow, sorry I can't finish it today, so decided to post a partial review. (Though the comment about not defining variable when measuring can be applied to the demo as well)

Thank you!

@ggridin ggridin requested a review from tcNickolas September 4, 2024 19:35
@ggridin
Copy link
Contributor Author

ggridin commented Sep 11, 2024

I looked at the two tasks this PR adds and left some comments. I'll take a look at the discussion and the demo tomorrow, sorry I can't finish it today, so decided to post a partial review. (Though the comment about not defining variable when measuring can be applied to the demo as well)

Thank you!

@tcNickolas - Maria, comments are addressed, waiting for re-review.

@ggridin ggridin closed this Sep 11, 2024
@ggridin ggridin reopened this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants