-
Notifications
You must be signed in to change notification settings - Fork 26
Add auxiliary basis set info to BasisSet #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rainli323
wants to merge
38
commits into
main
Choose a base branch
from
feature/RL/aux_basis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
c1da8f7
add aux basis to BasisSet, clean up existing constructors
rainli323 c0a566e
forgot to commit some
rainli323 606cbd2
documentations
rainli323 0145ade
fix some pytest
rainli323 8bda1e0
pre-commit
rainli323 0b9b3c2
fix documentation error
rainli323 4ce6740
Merge branch 'main' into feature/RL/aux_basis
rainli323 176bbd3
aux_basis default name
rainli323 4a7f4fa
Merge branch 'main' into feature/RL/aux_basis
rainli323 fde8d55
AI suggestions
rainli323 86debfe
Merge branch 'main' into feature/RL/aux_basis
rainli323 227fcaa
pre-commit
rainli323 5938118
merge eith DF_SCF for basis set related AI comments
rainli323 93f1cf7
more from DF_SCF branch, clean up pytest
rainli323 4773b5c
pre-commit
rainli323 6baaa8a
AI comments, the pybind is heavy, I don't know if I like it
rainli323 097b746
update pybind11 treatment of BasisSet. Finally decent
rainli323 9930897
Merge branch 'main' into feature/RL/aux_basis
rainli323 1463c40
pre-commit
rainli323 ab16ac8
AI commments
rainli323 1474861
update how to decide if shell is ecp or aux
rainli323 c0e0eff
pre-commit
rainli323 dbc2755
ai comment
rainli323 f0cb296
ai comments
rainli323 9fdc16a
pre-commit
rainli323 dcb8d97
change default of ecp name
rainli323 5133c1b
AI comment
rainli323 ede6dbf
AI comments
rainli323 83f9b91
bug fix and ai comments
rainli323 3c8b879
Merge branch 'main' into feature/RL/aux_basis
rainli323 f9ee640
AI commment
rainli323 34ab4b5
pre-commit
rainli323 62116f3
AI comments but regenerate constructors to make consistent.
rainli323 056e900
pre-commit
rainli323 766797b
AI comments
rainli323 7e098d1
pre-commit
rainli323 5fe70ed
remove dead code
rainli323 0fbb39e
AI comments on valid test and python export
rainli323 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.