Fix env version detection on systems with multiple system Pythons #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most Linux distributions allow installing multiple versions of Python side-by-side, where binaries are installed as `/usr/bin/pythonX.Y` and headers are installed into `/usr/include/pythonX.Y`. On such system PET will look for the first `patchlevel.h` header found in `/usr/include`, which would basically be the first Python version in the directory iteration order. Fix this by only considering versions that match the `MAJOR.MINOR` version found in `pyvenv.cfg` of the environment (if one exists). This is valid, because major Python upgrades almost always require the environment to be re-created.
DonJayamanne
approved these changes
Mar 24, 2025
bpasero
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most Linux distributions allow installing multiple versions of
Python side-by-side, where binaries are installed as
/usr/bin/pythonX.Yand headers are installed into
/usr/include/pythonX.Y.On such system PET will look for the first
patchlevel.hheader found in/usr/include, which would basically be the first Python version in thedirectory iteration order.
Fix this by only considering versions that match the
MAJOR.MINORversion found in
pyvenv.cfgof the environment (if one exists). Thisis valid, because major Python upgrades almost always require the
environment to be re-created.