Avoid misdetecting global Linux Python as virtualenv #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`/usr/bin` on Linux might contain unrelated 'activate.*` binaries which would make `is_virtualenv_dir` mistake it for a virtualenv: Environment (VirtualEnv) Executable : /usr/bin/python Symlinks : "/usr/bin/python" Environment (VirtualEnv) Executable : /bin/python Symlinks : "/bin/python" Environment (VirtualEnv) Executable : /usr/bin/python3 Symlinks : "/usr/bin/python3" Environment (VirtualEnv) Executable : /bin/python3 Symlinks : "/bin/python3" Environment (VirtualEnv) Executable : /usr/bin/python3.10 Symlinks : "/usr/bin/python3.10" Environment (VirtualEnv) Executable : /bin/python3.10 Symlinks : "/bin/python3.10" Environment (VirtualEnv) Executable : /usr/bin/python3.11 Symlinks : "/usr/bin/python3.11" This fix reduces the likelihood of this happening by excluding the common `bin` directories as well as tightening the `activate` test to avoid matching binaries like `activate-ssh-agent`.
DonJayamanne
approved these changes
Mar 23, 2025
roblourens
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/binon Linux might contain unrelatedactivate.*binarieswhich would make
is_virtualenv_dirmistake it for a virtualenv:This fix reduces the likelihood of this happening by excluding the
common
bindirectories as well as tightening theactivatetestto avoid matching binaries like
activate-ssh-agent.