Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tsconfig workaround after updating docusaurus #1623

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

mxschmitt
Copy link
Member

following the advice as per facebook/docusaurus#10733 (comment) and #1621 (comment).

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1623.centralus.azurestaticapps.net

@mxschmitt mxschmitt merged commit e0e76ff into main Dec 12, 2024
6 checks passed
@mxschmitt mxschmitt deleted the remove-tsconfig-hack branch December 12, 2024 23:28
@@ -0,0 +1 @@
/// <reference types="@docusaurus/theme-classic" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works, but my advice was rather to do this instead and improve typesafety of your config file:

import type {Config} from '@docusaurus/types';
import type * as Preset from '@docusaurus/preset-classic';

const config: Config = {
  title: 'My Site',
  presets: [
    [
      'classic',
      {
        docs: {
          
        },
        blog: {
          
        },
      } satisfies Preset.Options,
    ],
  ],
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants