Revise V2 field definitions in NetTraceFormat_v5.md #2302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec didn't accurately describe the encoding of field definitions inside the V2 Params area of NetTrace V5 metadata. I am updating the doc to align it with what the CLR generates and what TraceEvent parses.
Reference source for the parser:
perfview/src/TraceEvent/EventPipe/EventPipeMetadata.cs
Lines 397 to 404 in 0691921