flowey: add ADO trigger for tags #1272
Open
+61
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhillis
commented
May 1, 2025
| @@ -87,7 +97,10 @@ pub enum CiTrigger { | |||
| #[serde(rename_all = "camelCase")] | |||
| Some { | |||
| batch: bool, | |||
| branches: TriggerBranches, | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| branches: Option<TriggerBranches>, | |||
There was a problem hiding this comment.
The issue here was if branches was empty, the generated yml would get an entry that looked like
trigger:
branches: {}
which is not valid yml.
There was a problem hiding this comment.
Might be worth investigating if that's an issue with the yaml crate being used. Sounds like a upstream bug
There was a problem hiding this comment.
I'm not sure this is an issue with the yaml crate, seems like this is a valid fix to omit empty elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the ability to trigger pipelines when tags are created. While developing this change I also noticed that the current ADO CI triggers functionality did not generate correct yaml when an empty vector of trigger branches is specified, so a fix for that issue is included as well.