flowey: add kernel size check #1247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,11 @@ pub const MU_MSVM: &str = "24.0.4"; | |||
| pub const NEXTEST: &str = "0.9.74"; | |||
| pub const NODEJS: &str = "18.x"; | |||
| pub const OPENHCL_KERNEL_DEV_VERSION: &str = "6.6.63.2"; | |||
|
|
|||
| // Used to diff size between kernel versions, you should update this if you update the stable version | |||
| pub const OPENHCL_KERNEL_PREVIOUS_STABLE_VERSION: &str = "6.6.63.1"; | |||
There was a problem hiding this comment.
This is WIP - we should publish a baseline and use that similar to how we do the other binary size comparison.
|
What's missing here? |
Needs a rebase and also got a path wrong that needs fixing - need to focus on other stuff for now but will come back around to this eventually... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In closed source we have a kernel size check that fails when the kernel is updated and its size increases. It'd be nice to see it in open source as well.