Remove the CVM Guest VSM configuration env var #1238
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluck-msft
approved these changes
Apr 24, 2025
|
We can't enable this until we support VSM for multi-proc though right? |
|
I think we can, since all our existing guests won't be asking for it. |
|
I thought windows will always ask for it, if we mark it as available? |
|
I still see vsm getting revoked in the logs with this change on a plain tdx vm |
There might be some client skus or something that opt in automatically (and I remember trying to turn it off and finding it really difficult to do) |
|
Maybe we should wait a bit on this then. |
auto-merge was automatically disabled
April 25, 2025 20:28
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that both SNP and TDX support for guest vsm is nearing preview-feature-complete status this env var is no longer needed. It is up to the guest whether to enable VBS/VSM or not.