Update otel dependencies and add support for httpx2 entry point - #254
Conversation
6bad64b to
0a97f1b
Compare
Performance comparisonThreshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.
|
There was a problem hiding this comment.
🟡 Changes recommended
The current implementation doesn’t actually enable auto-discovery of the httpx2 entry point as described, and HTTPX2 enablement errors can currently surface as httpx instrumentation failures.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the distro’s dependency set to newer OpenTelemetry versions, and adds runtime enabling of HTTPX2ClientInstrumentor when the upstream opentelemetry-instrumentation-httpx package provides it, alongside a langchain-core minimum version bump and corresponding changelog/test updates.
Changes:
- Bump OpenTelemetry SDK/API/exporter and instrumentation package versions (and update
langchain-coreminimum version). - Add an
_setup_httpx2_instrumentation()helper and invoke it after instrumentinghttpx. - Add a unit test covering the “HTTPX2 not available” path and update the changelog for the unreleased version.
File summaries
| File | Description |
|---|---|
| tests/test_httpx_instrumentation.py | Adds a test ensuring HTTPX2 setup is a no-op when the import isn’t available. |
| src/microsoft/opentelemetry/_distro.py | Calls a new helper to enable HTTPX2ClientInstrumentor after httpx instrumentation. |
| pyproject.toml | Bumps OTel dependency versions and raises langchain-core minimum version. |
| CHANGELOG.md | Adds an unreleased entry describing the dependency and httpx2-related changes. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This PR addresses the following -
opentelemetry-instrumentation-httpxversion0.65b0now supports httpx2, so to be able to automatically discover theHTTPX2ClientInstrumentorwe now support the new entry point, while the httpx entry point will still continue to be auto-discovered.Bumped the otel dependencies to the latest version
Bumped the minimum version for
langchain-coreto fix the S360 item for this package