Skip to content

AOT MXBean #26

Merged
macarte merged 1 commit intoms-patches/AOTMxBeanfrom
macarte/AOTMxBean
Mar 12, 2026
Merged

AOT MXBean #26
macarte merged 1 commit intoms-patches/AOTMxBeanfrom
macarte/AOTMxBean

Conversation

@macarte
Copy link
Contributor

@macarte macarte commented Feb 24, 2026

passes tests

@swesonga
Copy link
Member

@macarte, which is the upstream JBS issue that got this work into tip?

@macarte
Copy link
Contributor Author

macarte commented Feb 26, 2026

@swesonga , here's the upstream issue: https://bugs.openjdk.org/browse/JDK-8369736

Note that the upstream implementation only provides one method; as the Leyden group wants to slowly introduce other functionality (currently the priority was only to provide the ability to stop training)

Where as this implementation which we introduced in our jdk25 release as more methods

@swesonga
Copy link
Member

@swesonga , here's the upstream issue: https://bugs.openjdk.org/browse/JDK-8369736

Note that the upstream implementation only provides one method; as the Leyden group wants to slowly introduce other functionality (currently the priority was only to provide the ability to stop training)

Where as this implementation which we introduced in our jdk25 release as more methods

Which JBS issue corresponds to this work in Leyden/premain?

@macarte
Copy link
Contributor Author

macarte commented Feb 27, 2026

@swesonga , here's the upstream issue: https://bugs.openjdk.org/browse/JDK-8369736
Note that the upstream implementation only provides one method; as the Leyden group wants to slowly introduce other functionality (currently the priority was only to provide the ability to stop training)
Where as this implementation which we introduced in our jdk25 release as more methods

Which JBS issue corresponds to this work in Leyden/premain?

https://bugs.openjdk.org/browse/JDK-8356572
openjdk/leyden#52

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this test have the if (isLeydenWorkflow()) checks in the Leyden PR? Why are these tests different?

@macarte macarte assigned macarte and swesonga and unassigned swesonga and macarte Mar 5, 2026
@macarte macarte requested a review from brianjstafford March 5, 2026 22:43
@macarte
Copy link
Contributor Author

macarte commented Mar 5, 2026

@swesonga , here's the upstream issue: https://bugs.openjdk.org/browse/JDK-8369736
Note that the upstream implementation only provides one method; as the Leyden group wants to slowly introduce other functionality (currently the priority was only to provide the ability to stop training)
Where as this implementation which we introduced in our jdk25 release as more methods

Which JBS issue corresponds to this work in Leyden/premain?

There was no JBS issue, work going into leyden/premain doesn't always have an associated JBS issue; here's the PR: openjdk/leyden#52

@macarte
Copy link
Contributor Author

macarte commented Mar 12, 2026

@swesonga , here's the upstream issue: https://bugs.openjdk.org/browse/JDK-8369736
Note that the upstream implementation only provides one method; as the Leyden group wants to slowly introduce other functionality (currently the priority was only to provide the ability to stop training)
Where as this implementation which we introduced in our jdk25 release as more methods

Which JBS issue corresponds to this work in Leyden/premain?

Sorry I thought I'd already replied to this; I didn't recall there being a JBS issue, but it turns out there was: https://bugs.openjdk.org/browse/JDK-8356572

here's the PR: openjdk/leyden#52

Of note, the not all the functionality in premain was moved to tip; but we kept that functionality in our MS build in order to prove out its value as we have a lot less overhead. Upstream would require documentation CSRs, and there's a process to removing bean functionality that the Leyden team wanted to avoid while we proved out its usefulness (which hopefully we get to do by supporting Jaz)

@macarte macarte merged commit ea905dd into ms-patches/AOTMxBean Mar 12, 2026
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants