Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of trailing optional inputs in pattern matching #1948

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Fix padding

d5899ed
Select commit
Loading
Failed to load commit list.
Open

Improve handling of trailing optional inputs in pattern matching #1948

Fix padding
d5899ed
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 15, 2024 in 0s

73.60% (-1.30%) compared to e6e3d52

View this Pull Request on Codecov

73.60% (-1.30%) compared to e6e3d52

Details

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.60%. Comparing base (e6e3d52) to head (d5899ed).

Files with missing lines Patch % Lines
onnxscript/rewriter/pattern_test.py 81.81% 4 Missing ⚠️
onnxscript/rewriter/pattern.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
- Coverage   74.89%   73.60%   -1.30%     
==========================================
  Files         262      262              
  Lines       28467    28489      +22     
  Branches     3284     3284              
==========================================
- Hits        21320    20968     -352     
- Misses       6138     6514     +376     
+ Partials     1009     1007       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.