Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aten_hardtanh_backward function #1715

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

xiaowuhu
Copy link
Contributor

@xiaowuhu xiaowuhu commented Jul 3, 2024

Depends on #1707, will add unit test after #1707 merged.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.20%. Comparing base (619f5ed) to head (1149291).

Files Patch % Lines
onnxscript/function_libs/torch_lib/ops/nn.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
- Coverage   75.24%   75.20%   -0.04%     
==========================================
  Files         242      242              
  Lines       25854    25857       +3     
  Branches     4658     4659       +1     
==========================================
- Hits        19453    19446       -7     
- Misses       5515     5523       +8     
- Partials      886      888       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 3, 2024

Test Results

     27 files  +     1       27 suites  +1   3h 23m 13s ⏱️ + 7m 39s
 10 515 tests ±     0    8 590 ✅  -     2    1 922 💤 ±     0  3 ❌ +2 
506 276 runs  +19 722  103 290 ✅ +4 287  402 983 💤 +15 433  3 ❌ +2 

For more details on these failures, see this check.

Results for commit 0bacde6. ± Comparison against base commit e824285.

@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Jul 3, 2024
@xiaowuhu xiaowuhu requested a review from xadupre July 4, 2024 04:28
@xiaowuhu xiaowuhu merged commit 0670951 into main Jul 4, 2024
43 of 44 checks passed
@xiaowuhu xiaowuhu deleted the xiaowu/addHardTanhBackward branch July 4, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

2 participants