Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph building to exclude input, output and initializer from value_info #1321

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

BowenBao
Copy link
Contributor

@BowenBao BowenBao commented Apr 1, 2024

Stack from ghstack (oldest at bottom):

Otherwise the emitted model proto instance violates the spec definition for value_info.
Reland #1320

BowenBao added a commit that referenced this pull request Apr 1, 2024
…e_info

ghstack-source-id: 4c40be31d6af9e243296bfa3dca08ae4a4a5b3b5
Pull Request resolved: #1321
@BowenBao BowenBao requested a review from justinchuby April 1, 2024 16:37
@BowenBao BowenBao changed the base branch from gh/BowenBao/19/base to main April 1, 2024 16:37
Copy link

github-actions bot commented Apr 1, 2024

Test Results

     18 files  ±     0      18 suites  ±0   1h 8m 3s ⏱️ + 18m 19s
  7 583 tests +     1   5 526 ✅ ±     0    2 054 💤  -      1   3 ❌ +2 
196 467 runs  +50 491  46 127 ✅ +12 685  150 329 💤 +37 797  11 ❌ +9 

For more details on these failures, see this check.

Results for commit 8c9ae0d. ± Comparison against base commit 2612107.

@justinchuby justinchuby merged commit fce220f into main Apr 1, 2024
21 of 33 checks passed
@justinchuby justinchuby deleted the gh/BowenBao/19/head branch April 1, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants