Address previous PR review comments from #1470 #1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijumeswani
changed the title
edgchen1
approved these changes
May 12, 2025
|
Thank you for the review. :) |
RyanUnderhill
pushed a commit
that referenced
this pull request
May 12, 2025
baijumeswani
added a commit
that referenced
this pull request
May 14, 2025
Address previous PR review comments from #1470 (#1473) Address QNN specific regressions (#1470) Fix array eos_token_id handling (#1463) Constrained decoding integration (#1381) Remove BF16 CPU from valid GQA configuration (#1469) Avoid adding providers if not requested (#1464) Persist provider options across ClearProviders, AppendProvider where possible (#1454) Fix accuracy issues with Gemma models (#1448) Add bfloat16 support in model builder (#1447) Add final norm for LoRA models (#1446) Update version to 0.8.0-rc3 --------- Co-authored-by: kunal-vaishnavi <[email protected]> Co-authored-by: Nenad Banfic <[email protected]> Co-authored-by: Nenad Banfic <[email protected]> Co-authored-by: Baiju Meswani <[email protected]> Co-authored-by: Abhishek Jindal <[email protected]> Co-authored-by: Ying Xiong <[email protected]> Co-authored-by: Michał Moskal <[email protected]> Co-authored-by: Kunal Vaishnavi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing open comments from previous PR #1470