Create mock IpmiCommandLib under IpmiFeaturePkg #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 28.20% 28.20%
=======================================
Files 44 44
Lines 3003 3003
Branches 404 404
=======================================
Hits 847 847
Misses 2144 2144
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Nov 1, 2024
apop5
reviewed
Nov 1, 2024
IpmiFeaturePkg/Test/Mock/Include/GoogleTest/Library/MockIpmiCommandLib.h
Outdated
Show resolved
Hide resolved
apop5
reviewed
Nov 1, 2024
IpmiFeaturePkg/Test/Mock/Library/GoogleTest/MockIpmiCommandLib/MockIpmiCommandLib.cpp
Outdated
Show resolved
Hide resolved
apop5
reviewed
Nov 1, 2024
IpmiFeaturePkg/Test/Mock/Library/GoogleTest/MockIpmiCommandLib/MockIpmiCommandLib.inf
Outdated
Show resolved
Hide resolved
TsunFeng
force-pushed
the
user/TsunFeng/MockIpmiCommandLib
branch
from
ba27863 to
2ccf9d4
Compare
VivianNK
reviewed
Nov 4, 2024
VivianNK
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create mock IpmiCommandLib under IpmiFeaturePkg
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
Unit tests component can call these mock functions success
Integration Instructions
N/A