Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Stop USB enumeration in case a malformed descriptor is found (#410)" #494

Merged

Conversation

makubacki
Copy link
Member

Description

This reverts commit 714d41b.

Some devices are dependent on this functionality and can be important
sources of input during boot. Until a more robust solution is devised
that can support these devices, this change is reverted.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Verified a USB mass storage device that failed to enumerate with
the change can be enumerated after reverting it.

Integration Instructions

N/A

…icrosoft#410)"

This reverts commit 714d41b.

Some devices are dependent on this functionality and can be important
sources of input during boot. Until a more robust solution is devised
that can support these devices, this change is reverted.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki requested review from os-d and kenlautner July 18, 2023 20:38
@makubacki makubacki linked an issue Jul 18, 2023 that may be closed by this pull request
@makubacki makubacki merged commit b21ddf6 into microsoft:release/202208 Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Improve USB descriptor robustness
3 participants